[LARTC] ESFQ not so fair?

[Andy Furniss]

Patrick McHardy wrote:
> Andy Furniss wrote:
> 
>>Corey Hickey changed his esfq to use jhash for dst/src/fw - copy of his
>>announce below.

> 
> Using jhash is a probably a good idea, the "improved" hash is broken
> and will cause reordering in some circumstances:
> 
> return (h - q->dyn_min) * (q->hash_divisor - 1) / q->dyn_range;
> 
> dyn_min, dyn_max and dyn_range, as their name suggests, are adjusted
> dynamically, so the hash function changes whenever one of these values
> changes, resulting in reordering of packets belonging to a single flow.
> 

Oops I thought he did use jhash don't know where I got that from.

Andy.