[LARTC] [PATCH] Problem with wrong using of qdisc/filter in tc

Jaroslaw J. Pyszny arghil@tlen.pl
Fri, 18 Jul 2003 23:31:20 +0200


--n8g4imXOkfNTN/H1
Content-Type: text/plain; charset=iso-8859-2
Content-Disposition: inline
Content-Transfer-Encoding: 8bit

Hi,

  I found bug in tc (wrong using of qdisc/filter will cause seg fault):
   tc qdisc add u32 help        // u32 is filter
  
  In function get_qdisc_kind (get_filter_kind) we search for struct
  qdisc_util (filter_util) with name *_util (in example for u32 is 
  u32_util - it's ok, but it isn't qdisc)

  My suggestion is to change name to:
   *_utilQ (for qdisc)
   *_utilF (for filter)

  then if we search for qdisc we won't get filter (and vice versa).
  See patch.
  
  I've tested it on version 2.4.7 (ss010824 and ss020116-try), but the bug
  should also affect older versions.
   
  I wrote to A. Kuznetsov, but I didn't get response. Maybe my email
  lost or something else ;)

  Best regards
  Jarek
-- 
8  \\|||//  Jaroslaw J. Pyszny (arghil AT tlen DOT pl)      \\|||//
b   (o|o)         "Vitae,non scholae,discimus"               (o|o)
i  --\_/--  Linux user: #96704 (http://counter.li.org)      --\_/-- 
t =-> Masz 8-bit. komputer i chcesz siê go pozbyc - daj znac. <-=

--n8g4imXOkfNTN/H1
Content-Type: application/octet-stream
Content-Disposition: attachment; filename="iproute2-2.4.7-fix_names.patch.bz2"
Content-Transfer-Encoding: base64

QlpoOTFBWSZTWcwQ8BgACH3fgAIwWn//+n+3PgC/7//6YAd/BZ4ztOZhqT4sgAAAJRBIRhBo
9TzVMTQ8UMTE9CNDIaDEEoptExppShoAaHtUAANpAAAAcwJiaDCZMmTIwmCaaZGJgCGAan+q
lRo0NNABkBoNAAAAAACKlTMo9CA0wmIZAZMmACMQwmgCopBGhNAmT0KaI2o0DyNIGIyBoNqZ
En1v52QxIWRipgjNZIc3UxJkrk+V1yGJDLC2LZD2LKszkUPixLJkp77NFVZ7cTGE13WatwsT
V8Xr6LbLTyq4YyI0I0dch2YI2ifisehrZiy2S2fb2R17llW1dbHgkQqLH3J/bYbVNhw4GcU/
JMMVexzXNbM1Jnq6epIgWkVESwCFWQS00DoghAJgE4hJZEM5IHZr0YmK+VbWdGkNemuAQf7n
l5foCEjBqkF1Jbmjcs5wtKKQCfmU85K+iSk5Jbl2CsXZdpStJYljbvAAAAAAL1/tAAAAAAMO
WfeKxSlEhZkl8VwEtSlJaEDtmuBs6d/3YNv5bic2P9vvo3UbZ6OcyIGVRDqKS+EdIccpaAUk
FlUHMYkQrEUU+R8duEISwfENrwg/r9PT08WafS+z/2Hiytr5nkRSkUjAlJSZ9KSXLwQRIEIQ
hBEILbcYwONqLPafQ2cjU0x2/C+5cXHb7kuM31L8FaM7nrrlnjLP6s78Li43dr3iKR3yJRBQ
QUEOpxbabbdne1N7S5+22/oW2tScWib1aUrQ74rhmxrh8Xxh5wzSicRERFYjGHnDNKJ+ALgI
aBSkluoAAAAAAABEAEQABWTlkpck0YkqTMRU/qqRfVM1lXC40YGaZJl6ZYyTIej6R09tu2Ub
YxGeduXBWhGlJdNLc95llbmxjOaE2cNJWScPO1xasHkEaCN22CNssrbcTXWxLNiORHBytej5
GTf9YiqjvIuLKWg6bjUQo7zmXOwVAqKgJONW1VexrynKaMoyywjGMTGMcVb5vQ2rdYnK8ZOQ
rDGoWtI3FtUW2EOZbWSEGgKKFBWfSuVXQxhouGlbaWZC5QrWkrIiKRVtdHu8pzSs6rv697fM
lXfgwSzOptdtt227CNLnht7T7LbxTSVhkR+d8HaifwCUT2iVDttSWCbRXCK4hT0+BSIY4Cw3
C1zTvFyewpnV2CmwVkFJwpt3ikBeJEygkgpGSlDTEKcZOFYxZQrEDILAecUmrBbJLJPeP2yk
95Q83wZ4xhhVttttoVVVFAVODcnDgcnDhRpV9I2OXx5xFM2k2cGIrKWmLxl9M51vd9JSurur
IDAKAoDu/mxjL2jOMtmjPLnpHnS0sqtWD78W9sj/j7upHaJ6T7fn9h5z5uEkaaZdSMGFPxJD
qmtttsEVbBTXPeb5u/uusM5rrg1mn9BPQjtPwR7iPGSbNzv45cTjNN5y7FiI65ItrwI9Zz8z
OGcRuEaQ8mzvnkR+GZvMeCPwwf7LKF3EXzt7juTLLjJ0NQy7rVtW22223xR4+PA4NupN2TXX
UymvcjyPN0/zttsbTbPPMzmfuTps6aKR0D1kSycoU48eJ+ycsrOKSKEbST53aZo8CJxmjzd+
GcnP4rDejt/LhIviDhEZOpzcIeVPWIqM5wMCOL1MVVW22rVtsvW3Hk/KI8JEeTqhI+KTKSOX
Trx6IzfElByNdcj0m7mEd8iMmj2dq2WrbVr5SGMLVrAYw3STz6eHqJToR4yeHZeV7Lbbbztt
vGoxI+vgkjijhI4OHDgahG9w3ia66mMZ6FcROiyLI+J1o75J0E224HCcPop3IyOtOcpwfNI1
Pxti2FsXkk+V+ZHe88C0LiEXvUFkae3u7u47Jx8yItNNNDRp64SOqTrcjIidyPR06yTInqke
xOfPmc3PtE+RHsT9ZH2E6EdcjshI4ETsSfInYIssjKRWRPM6kjmslWJsR/8XckU4UJDMEPAY

--n8g4imXOkfNTN/H1--